Skip to content

fix: user-events logs exporter - alternate build pattern #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cijothomas
Copy link
Member

Bundle options directly into processor, as users are ultimately going to build a processor.
Expose Processor, builder in public API - users still don't know about reentrantprocessor - they get back something impl LogProcessor.
Populate PartB.name from event_name, if available.
Hard code "Log" as user_event's event_name
(TODO: Add support for a callback for user-event event_name.)

TODO: Add custom error Struct.

Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 67.64706% with 44 lines in your changes missing coverage. Please review.

Project coverage is 50.9%. Comparing base (39da950) to head (fede2f8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...entelemetry-user-events-logs/src/logs/processor.rs 76.2% 28 Missing ⚠️
...pentelemetry-user-events-logs/src/logs/exporter.rs 13.3% 13 Missing ⚠️
opentelemetry-user-events-logs/src/lib.rs 0.0% 2 Missing ⚠️
stress/src/user_events.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #262   +/-   ##
=====================================
  Coverage   50.8%   50.9%           
=====================================
  Files         64      63    -1     
  Lines       8513    8507    -6     
=====================================
+ Hits        4331    4332    +1     
+ Misses      4182    4175    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas marked this pull request as ready for review May 16, 2025 02:44
@cijothomas cijothomas requested a review from a team as a code owner May 16, 2025 02:44
@cijothomas cijothomas merged commit 3a4b4de into open-telemetry:main May 20, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants